How to mod the game to include unit limits?

[cazfi]

In the Ruleset, the units that are defined as "DefendGood" seem to be overprioritized by the AI.

Now that you mention that, I should check what that role even does in the code level. Maybe it's completely redundant, or worse, only causing AI to miscalculate (as you experience indicates), nowadays. AI calculates actual defense usability of the units quite (relative to how much simplifications and assumptions it otherwise does) accurately, so does the "DefendGood" only add want on top of the correct value?

[Ignatus]

As I could find out, "DefendGood" is just doubles the want of building city defender that is calculated for "DefendOk" (without either flag, a unit is not considered one... wait, where do all these battleships come from?); also, "DefendGood" serve as king's bodyguards. I doubt AI can calculate all the ballance issues to produce sensible hosting without hints, but it may well happen that the current system of hints is not sufficient.

[Sanguivorant]

For that one I have a patch in testing.

I would be willing to test it honestly.

If you can build freeciv yourself, the patch is attached to that ticket.

Otherwise, what Operating System are you using?

I'm using Linux.

In the Ruleset, the units that are defined as "DefendGood" seem to be overprioritized by the AI.

Now that you mention that, I should check what that role even does in the code level. Maybe it's completely redundant, or worse, only causing AI to miscalculate (as you experience indicates), nowadays. AI calculates actual defense usability of the units quite (relative to how much simplifications and assumptions it otherwise does) accurately, so does the "DefendGood" only add want on top of the correct value?

From days of experimenting it seems that the AI calculates based primarily on four things:
The DefenceGood tag
Defence
Hitpoints
Firepower
Between two units of the same defence level, the AI will choose the one with the tag DefenceGood. So for example, even if a Legion has the same defence as a phalanx, it will always prefer phalanx because it has the DefenceGood tag. If you give the Legion DefenceGood, it doesn't seem to change anything until you add extra hitpoints.

I also did it between Phalanx and Archers. Despite archers having 1 defence, if they have the DefenceGood tag, and phalanx do not, the AI will build them. I might try a ruleset where I remove the tag entirely and see what the AI decides to do.

[cazfi]

I would be willing to test it honestly.

If you can build freeciv yourself, the patch is attached to that ticket.

Otherwise, what Operating System are you using?

I'm using Linux.

So flatpak would do? The patch just went in, with the little testing it has received, so will be in the nightly in a couple of hours: https://files.freeciv.org/nightly/S3_0/flatpak/