Amphiteatre or Amphiteater ... Inconsistencies.

[omero]

Hello.

Noticed something about Amphitheatre/Amphitheater and I thought I would report it.

Code: Select all

Wed May 17 06:01:55 CEST 2023
-----------------------------

[omero@naldvras:/usr/local/src/freeciv/freeciv-2.6.9.2023-04-27.1]
$egrep -ri "[aA]mphitheat.*" ./*|grep -v translations
./data/multiplayer/techs.ruleset:helptext = _("Improves the effect of Amphitheaters.")
./data/multiplayer/README.multiplayer:- Colosseum: Renamed to "Amphitheater", and cost decreased to 60 (was 70).
./data/multiplayer/effects.ruleset:[effect_amphitheatre]
./data/multiplayer/effects.ruleset:      "Building", "Amphitheatre", "City"
./data/multiplayer/effects.ruleset:[effect_amphitheatre_1]
./data/multiplayer/effects.ruleset:      "Building", "Amphitheatre", "City"
./data/multiplayer/buildings.ruleset:; "Colosseum" renamed to "Amphitheater" as suggested by
./data/multiplayer/buildings.ruleset:[building_amphitheatre]
./data/multiplayer/buildings.ruleset:name            = _("Amphitheater")
./data/multiplayer/buildings.ruleset:rule_name       = "Amphitheatre"        ; en_GB used originally
./data/civ2civ3/techs.ruleset:effect of Amphitheaters, and increases city vision radius.\
./data/civ2civ3/README.civ2civ3:  Amphitheatre), University, Bank, Stock Exchange, Port Facility, SDI
./data/civ2civ3/buildings.ruleset:name            = _("Amphitheater")
./data/sandbox/techs.ruleset:effect of Amphitheaters, and increases city vision radius.\
./data/sandbox/buildings.ruleset:name            = _("Amphitheater")

#EOT
~

I have excluded (grep -v) the translations in the report.
The search is performed on the "vanilla" v2.6.9 source tree, no alterations/mods.

[cazfi]

Sorry, I don't spot any errors there. It's a bit hard to follow as "name" is different from "rule_name"

Apparently it has been Amphitheatre originally:

Code: Select all

rule_name       = "Amphitheatre"        ; en_GB used originally

but user-visible "name" has been changed to "Amphitheater".

The "rule_name" exist (separate from name) for the very reason of making such changes to the user-visible "name" without breaking backward compatibility (e.g. savegames)

[omero]

I understand. Thank you for clarifying. I thought Amphitheater was spelled wrong and inconsistent with the rule name.
Colosseo in Roma is still Anfiteatro Flavio