Can Bombard attack NOT end movement?

Contribute, display and discuss rulesets and modpacks for use in Freeciv here.
User avatar
Corbeau
Elite
Posts: 925
Joined: Mon Jan 13, 2014 11:13 pm

Can Bombard attack NOT end movement?

Postby Corbeau » Mon Apr 29, 2019 9:15 pm

Like the title says. Regardless of how many MPs a bombarding unit has left, after it attacks, its movement ends. Is it possible to switch this so that the unit can move on?

Ignatus
Veteran
Posts: 149
Joined: Mon Nov 06, 2017 12:05 pm
Location: St.Petersburg, Russia
Contact:

Re: Can Bombard attack NOT end movement?

Postby Ignatus » Tue Apr 30, 2019 9:57 am

Currently not, it is hardcoded in server/unithand.c. As far as I can see, you even can not give the mp back by a callback, since action_started_unit_unit is called before the bombardment, and then nobody is killed.

And what's the trouble? A bombarder that bombs and runs (or bombs and bombs and bombs) seems to be an imbalance.

User avatar
Corbeau
Elite
Posts: 925
Joined: Mon Jan 13, 2014 11:13 pm

Re: Can Bombard attack NOT end movement?

Postby Corbeau » Tue Apr 30, 2019 3:56 pm

Ignatus wrote:And what's the trouble? A bombarder that bombs and runs (or bombs and bombs and bombs) seems to be an imbalance.

Only if it's a Bomber (airplane). However, I'm thinking about Partisans. Hit'n'run tactics, not much damage, but some disruption and hard to catch.

Ignatus
Veteran
Posts: 149
Joined: Mon Nov 06, 2017 12:05 pm
Location: St.Petersburg, Russia
Contact:

Re: Can Bombard attack NOT end movement?

Postby Ignatus » Thu May 16, 2019 7:07 pm

Only close thing I can imagine - set bombardment radius to more than 1, then the attacked side would not easily see where the attacker is. But this parameter is currently set only for all bombarders in the ruleset.

User avatar
Corbeau
Elite
Posts: 925
Joined: Mon Jan 13, 2014 11:13 pm

Re: Can Bombard attack NOT end movement?

Postby Corbeau » Fri May 17, 2019 9:41 am

Ignatus wrote:bombardment radius

Is this a ruleset/server feature or coding only?

Ignatus
Veteran
Posts: 149
Joined: Mon Nov 06, 2017 12:05 pm
Location: St.Petersburg, Russia
Contact:

Re: Can Bombard attack NOT end movement?

Postby Ignatus » Fri May 17, 2019 3:17 pm

It's a ruleset parameter. E.g. in webperimental/game.ruleset (2.6)

Code: Select all

bombard_max_range = 3

Ignatus
Veteran
Posts: 149
Joined: Mon Nov 06, 2017 12:05 pm
Location: St.Petersburg, Russia
Contact:

Re: Can Bombard attack NOT end movement?

Postby Ignatus » Sat May 18, 2019 7:56 am

Or it would not help. The server sends to the client combat info that always shows combating units within the player's sight, even if both units are invisible otherwise. At least, so it is designed in 2.6.

Ignatus
Veteran
Posts: 149
Joined: Mon Nov 06, 2017 12:05 pm
Location: St.Petersburg, Russia
Contact:

Re: Can Bombard attack NOT end movement?

Postby Ignatus » Tue May 21, 2019 9:24 pm

Requested a callback that could give some mp back: HRM#817749.

User avatar
Corbeau
Elite
Posts: 925
Joined: Mon Jan 13, 2014 11:13 pm

Re: Can Bombard attack NOT end movement?

Postby Corbeau » Wed May 22, 2019 9:44 am

Cool. Thanks.