non-native attack failed

[Wahazar]

I have ruleset with unit class, which has "AttackNonNative", "AttFromNonNative" flags (freeciv 2.6).
This unit can be transported, but sometimes attack from transport board doesn't work, there is following message in console instead:

Code: Select all

1: in request_transport() [transportdlg.c::104]: assertion 'unit_list_get(potential_transports, 0) == best_transport' failed.

What can be a reason of such behavior?

[Ignatus]

Likely, the client tries to board the ememy instead of attacking it. This is strange, control.c code calls request_transport() only if the destination move tile has unlivable terrain. What client do you use?

[Alien Valkyrie]

This is strange, control.c code calls request_transport() only if the destination move tile has unlivable terrain.

If I understand this correctly, that's precisely the case – an attack from a non-native tile against another non-native tile.

[Wahazar]

Likely, the client tries to board the ememy instead of attacking it. This is strange, control.c code calls request_transport() only if the destination move tile has unlivable terrain. What client do you use?

Both Qt and Gtk has this effect.
Yes, attacking unit (turret) have no livelable terrain at all (it can't move by itself, only by transport), so it attack from unlivable at unlivable.

[Ignatus]

Ah yes, now I understand. Yes, it's a bug in client logic. HRM#881350

[Wahazar]

Another issue (maybe related) is that it is not possible to use goto to attack unit on non-native tile.

[Ignatus]

Put a patch on HRM. In my test, it worked. I hope it does not break other stuff where request_transport is called