2.6 National_History effect inconsistence

Contribute, display and discuss rulesets and modpacks for use in Freeciv here.
Wahazar
Elite
Posts: 362
Joined: Mon Jul 02, 2018 1:49 pm

2.6 National_History effect inconsistence

Postby Wahazar » Sun May 17, 2020 7:38 pm

I defined National_History with City range condition - it is not working (no culture points appear in Demographic Report).
Player range works well, City range doesn't, but also no warning or error is thrown due to improper usage of condition range
(in contrary to improper Player range used in Improvement effect).
Augmented2 ruleset/modpack for freeciv2.6: viewtopic.php?f=11&t=91047

Ignatus
Elite
Posts: 489
Joined: Mon Nov 06, 2017 12:05 pm
Location: St.Petersburg, Russia
Contact:

Re: 2.6 National_History effect inconsistence

Postby Ignatus » Sun May 17, 2020 7:57 pm

Yes, it's a player-range effect. You can use wonders with range "Player", but otherwise a city can add only to its own "History" and "Performance". Don't know, maybe we could fix it in future releases. But generally you may use these effects, all culture effects are additive for a player.

In Civ3, for comparison, culture is national (when a city is conquered the conqueror gets no culture) but city-bound (the loser loses the amount of culture producedin the city and can regain it getting the city back, and the irredentional rebel probability is heavily bound to the ratio of national cultures ever presented in the city).

Wahazar
Elite
Posts: 362
Joined: Mon Jul 02, 2018 1:49 pm

Re: 2.6 National_History effect inconsistence

Postby Wahazar » Sun May 17, 2020 9:53 pm

Ignatus wrote:Yes, it's a player-range effect.

It is not an issue, the problem is that there is no warning/error when City range is used, instead effect is ignored and no points are counted either for city nor player.
Augmented2 ruleset/modpack for freeciv2.6: viewtopic.php?f=11&t=91047

Ignatus
Elite
Posts: 489
Joined: Mon Nov 06, 2017 12:05 pm
Location: St.Petersburg, Russia
Contact:

Re: 2.6 National_History effect inconsistence

Postby Ignatus » Mon May 18, 2020 7:16 am

Wahazar wrote:
Ignatus wrote:Yes, it's a player-range effect.

It is not an issue, the problem is that there is no warning/error when City range is used, instead effect is ignored and no points are counted either for city nor player.

Yes, sorry, missed the "no". HRM#874090

jpsm
Veteran
Posts: 97
Joined: Sun Nov 01, 2020 8:14 pm

Re: 2.6 National_History effect inconsistence

Postby jpsm » Wed Nov 04, 2020 3:59 am

Ignatus wrote:In Civ3, for comparison, culture is national (when a city is conquered the conqueror gets no culture) but city-bound (the loser loses the amount of culture producedin the city and can regain it getting the city back, and the irredentional rebel probability is heavily bound to the ratio of national cultures ever presented in the city).

I recommend to change this because historically when some empire conquer a place culturally advanced (such as the conquest of Greece by Rome) it do culturally benefits the conqueror.