Cosmetic bug in tech tree and in-game help browser

Various topics about the game, the website, or anything else Freeciv related that doesn't fit elsewhere.
Post Reply
User avatar
Corbeau
Elite
Posts: 1291
Joined: Mon Jan 13, 2014 11:13 pm

Cosmetic bug in tech tree and in-game help browser

Post by Corbeau »

There is a problem with some items depiction in the tech tree and in-game help.

This is the situation. First, buildings.ruleset:

Code: Select all

reqs	=
    { "type", "name", "range", "negated"
      "Tech", "Navigation", "Player", FALSE
      "Terrain", "Ocean", "Adjacent", FALSE
      "Tech", "The Republic", "Player", TRUE
      "Tech", "Democracy", "Player", TRUE
    }
The idea is that it is impossible to build this if your government is Democracy or Republic. Everything works fine, except how it is shown in the mentioned cases - see attached image.

So, the client grabs everything from the requirements, regardless if it allows or prevents the feature, and puts it for display. It even creates the funny situation where something is "prevented" and "allowed" in the same screen.

It may be confusing for someone unacquainted with the feature, but other than that, it's not a functional problem. I'm simply drawing attention in case someone wants to fix it.
Attachments
cosmeticbug.png
--
* Freeciv LongTurn, a community of one-turn-per-day players and developers
* LongTurn Blog - information nexus with stuff and stuff and stuff
* Longturn Discord server; real-time chatting, discussing, quarrelling, trolling, gaslighting...
Ignatus
Elite
Posts: 644
Joined: Mon Nov 06, 2017 12:05 pm
Location: St.Petersburg, Russia
Contact:

Re: Cosmetic bug in tech tree and in-game help browser

Post by Ignatus »

Is it 2.5 or 2.6?
User avatar
Corbeau
Elite
Posts: 1291
Joined: Mon Jan 13, 2014 11:13 pm

Re: Cosmetic bug in tech tree and in-game help browser

Post by Corbeau »

It's 2.5.
--
* Freeciv LongTurn, a community of one-turn-per-day players and developers
* LongTurn Blog - information nexus with stuff and stuff and stuff
* Longturn Discord server; real-time chatting, discussing, quarrelling, trolling, gaslighting...
Ignatus
Elite
Posts: 644
Joined: Mon Nov 06, 2017 12:05 pm
Location: St.Petersburg, Russia
Contact:

Re: Cosmetic bug in tech tree and in-game help browser

Post by Ignatus »

As forum says, you should replace "Tech" on "Government" in the two negated reqs to get the desired effect, IDK will the governments be described correctly then, but yes, requirement negation is often improperly goes to autohelp. Be patient, we have invented it only two or three versions ago :P
User avatar
Corbeau
Elite
Posts: 1291
Joined: Mon Jan 13, 2014 11:13 pm

Re: Cosmetic bug in tech tree and in-game help browser

Post by Corbeau »

Ok, effectively, I made a typo in the original post. Yesm it's supposed to depend on whether the tech was discovered, not on the government.

Which has nothing to do with the issue: putting an image where it shouldn't be.

And, like I said, it's cosmetic and not a problem for someone who is aware of it. Just pointing it out for te Higher Beings to see ;)
--
* Freeciv LongTurn, a community of one-turn-per-day players and developers
* LongTurn Blog - information nexus with stuff and stuff and stuff
* Longturn Discord server; real-time chatting, discussing, quarrelling, trolling, gaslighting...
Post Reply