Page 1 of 2

bugs in 2.5.3 and 2.5.4

Posted: Sun Apr 24, 2016 11:08 am
by fomalhaut
I'm making new ruleset and I've found several bugs or inappropriate messages.
Of course I know Gna! but I don't know the answer for Antispam test.
("What Git command do you use to duplicate a sheep?")

The following bugs has occurred in ver 2.5.3.

1. If you set "illness_pollution_factor" as 256 in game.ruleset, the amounts of pollution becomes 0.
error message : Trying to put 256 into 8 bits; it will result 0 at receiving side.

2. Exchanging of world map doesn't update city size.

3. Spy can't empty the granary by poisoning the water supply.

4. If sea unit is inside a city, their winning percentage against enemy units is always displayed as 0%.

5. The explanatory text of 'techlost_donor' is inadequate.
"If you give an invention via a treaty..."
This should also include war or stealing.

6. When spy steals technology in experimental ruleset, unavailable advanced techs are displayed in the selecting list.
Spy should only select root techs in the same way as a diplomatic meeting.

7. In some messages, "Leader" is not translated.
e.g. 'Unable to defend Leader, *** has lost the game.'

8. If Air units have 0 movement points, we can't unload them in the outside of the city.
But I want to add "Nuclear Bomb" to my ruleset and drop it.

Re: bugs in 2.5.3

Posted: Sun Apr 24, 2016 1:19 pm
by Caedo
fomalhaut wrote:1. If you set "illness_pollution_factor" as 256 in game.ruleset, the amounts of pollution becomes 0.
error message : Trying to put 256 into 8 bits; it will result 0 at receiving side.

That's not a bug, that's just how computers work: A byte (the smallest reasonably usable unit of information) can contain values from 0 to 255.
fomalhaut wrote:8. If Air units have 0 movement points, we can't unload them in the outside of the city.
But I want to add "Nuclear Bomb" to my ruleset and drop it.

"It's not a bug, it's a feature", though I think this is annoying as well. I'll create a ticket for it.
EDIT: Here it is: patch #7144

Also, the command is just "clone".

Re: bugs in 2.5.3

Posted: Sun Apr 24, 2016 4:24 pm
by fomalhaut
Caedo wrote:That's not a bug, that's just how computers work: A byte (the smallest reasonably usable unit of information) can contain values from 0 to 255.

But in /common/game.h , it's set like this.
#define RS_DEFAULT_ILLNESS_POLLUTION_PCT 50
#define RS_MIN_ILLNESS_POLLUTION_PCT 0
#define RS_MAX_ILLNESS_POLLUTION_PCT 500

From this, I thought the maximum value was 500.
bug? or not bug?

Caedo wrote:EDIT: Here it is: patch #7144

Thanks!

Re: bugs in 2.5.3

Posted: Sun Apr 24, 2016 9:11 pm
by cazfi
fomalhaut wrote:1. If you set "illness_pollution_factor" as 256 in game.ruleset, the amounts of pollution becomes 0.
error message : Trying to put 256 into 8 bits; it will result 0 at receiving side.

What happens here is that the value is not sent to the client. The server should still use correct value when determining if illness hits the city. I'll open a bug about the network protocol issue.

Re: bugs in 2.5.3

Posted: Sun Apr 24, 2016 9:36 pm
by cazfi
cazfi wrote:
fomalhaut wrote:1. If you set "illness_pollution_factor" as 256 in game.ruleset, the amounts of pollution becomes 0.
error message : Trying to put 256 into 8 bits; it will result 0 at receiving side.

What happens here is that the value is not sent to the client. The server should still use correct value when determining if illness hits the city. I'll open a bug about the network protocol issue.

-> bug #24607

Re: bugs in 2.5.3

Posted: Sun Apr 24, 2016 9:50 pm
by cazfi
fomalhaut wrote:7. In some messages, "Leader" is not translated.
e.g. 'Unable to defend Leader, *** has lost the game.

-> bug #24608

Re: bugs in 2.5.3

Posted: Sun Apr 24, 2016 9:56 pm
by cazfi
fomalhaut wrote:5. The explanatory text of 'techlost_donor' is inadequate.
"If you give an invention via a treaty..."
This should also include war or stealing.
Well, the text is correct. Or would you want it to explain that "... but this does not apply to techs another player steals from you"?

Re: bugs in 2.5.3

Posted: Sun Apr 24, 2016 10:02 pm
by cazfi
cazfi wrote:
fomalhaut wrote:5. The explanatory text of 'techlost_donor' is inadequate.
"If you give an invention via a treaty..."
This should also include war or stealing.
Well, the text is correct. Or would you want it to explain that "... but this does not apply to techs another player steals from you"?
Sorry, you are right. Checking the source code, it does apply to any kind of tech transfer nowadays (I just remembered that the feature was originally specifically for penalizing excessive tech trading in multiplayer)

Re: bugs in 2.5.3

Posted: Sun Apr 24, 2016 10:13 pm
by cazfi
fomalhaut wrote:5. The explanatory text of 'techlost_donor' is inadequate.
"If you give an invention via a treaty..."
This should also include war or stealing.

-> bug #24609

Re: bugs in 2.5.3

Posted: Sat May 14, 2016 5:27 am
by fomalhaut
fomalhaut wrote:3. Spy can't empty the granary by poisoning the water supply.

4. If sea unit is inside a city, their winning percentage against enemy units is always displayed as 0%.


screenshot: