Multiplayer PBEM Diplomacy Bug Still There

Web version of freeciv at play.freeciv.org
sirkirby
Posts: 2
Joined: Tue Sep 19, 2017 10:02 pm

Multiplayer PBEM Diplomacy Bug Still There

Postby sirkirby » Tue Sep 26, 2017 1:29 pm

I didn't get a reply posting this in the other thread, so I thought I would start a new thread. Here's my question/concern:

Gents, first let me say... great game! My friends and I are having a wonderful time playing this game.

Now here's my problem... I am still having an issue with diplomacy in the multiplayer game. I don't see an option anywhere to do any diplomacy. We're stuck in perpetual war. I tried establishing an embassy but that did not open up the option anywhere. Am I doing something wrong?

Thanks in advance.

cazfi
Elite
Posts: 1472
Joined: Tue Jan 29, 2013 6:54 pm

Re: Multiplayer PBEM Diplomacy Bug Still There

Postby cazfi » Tue Sep 26, 2017 2:25 pm

PBEM -> I think this is an freeciv-web at play.freeciv.org rather than regular desktop client, right?

User avatar
Corbeau
Elite
Posts: 719
Joined: Mon Jan 13, 2014 11:13 pm

Re: Multiplayer PBEM Diplomacy Bug Still There

Postby Corbeau » Tue Sep 26, 2017 4:57 pm

Did you check the Nations screen? When you have an embassy with someone, click on that player, there should be a "Meet" button.

madmax
Posts: 33
Joined: Sun Mar 26, 2017 5:34 pm

Re: Multiplayer PBEM Diplomacy Bug Still There

Postby madmax » Thu Sep 28, 2017 5:40 pm

Not in PBEM. PBEM games do not support diplomacy.

dareg
Posts: 3
Joined: Thu Sep 28, 2017 6:26 pm

Re: Multiplayer PBEM Diplomacy Bug Still There

Postby dareg » Thu Sep 28, 2017 6:28 pm

Is there a specific reason for not supporting diplomacy in PBEM ? Is it a bug ?

User avatar
AndreasR
Elite
Posts: 685
Joined: Thu May 02, 2013 10:26 pm
Location: Norway

Re: Multiplayer PBEM Diplomacy Bug Still There

Postby AndreasR » Thu Sep 28, 2017 7:50 pm

dareg wrote:Is there a specific reason for not supporting diplomacy in PBEM ? Is it a bug ?


Diplomacy isn't working in PBEM games, because the diplomacy code in Freeciv was developed a long time ago before Freeciv-web got PBEM support, and no one has done the development work to implement diplomacy support for PBEM yet. The main issue is that the human players are never connected to the same server in PBEM games, since in PBEM games the next player loads the savegame from the previous player, turn after turn. The diplomacy buttons have also been disabled in PBEM games in Freeciv-web. I guess it should only take a few hours to fix. Patches and pull-requests welcome!

cazfi
Elite
Posts: 1472
Joined: Tue Jan 29, 2013 6:54 pm

Re: Multiplayer PBEM Diplomacy Bug Still There

Postby cazfi » Thu Sep 28, 2017 10:14 pm

AndreasR wrote:
dareg wrote:Is there a specific reason for not supporting diplomacy in PBEM ? Is it a bug ?


Diplomacy isn't working in PBEM games, because the diplomacy code in Freeciv was developed a long time ago before Freeciv-web got PBEM support, and no one has done the development work to implement diplomacy support for PBEM yet. The main issue is that the human players are never connected to the same server in PBEM games, since in PBEM games the next player loads the savegame from the previous player, turn after turn. The diplomacy buttons have also been disabled in PBEM games in Freeciv-web. I guess it should only take a few hours to fix. Patches and pull-requests welcome!


Freeciv savegames have contained open diplomacy meetings for years now. What else is needed?

User avatar
AndreasR
Elite
Posts: 685
Joined: Thu May 02, 2013 10:26 pm
Location: Norway

Re: Multiplayer PBEM Diplomacy Bug Still There

Postby AndreasR » Sat Sep 30, 2017 6:09 am

PBEM games on Freeciv-web was initially a 2 player duel, where the winner got points in the ranking table. In a 2 player duel, the idea at the time was that diplomacy was not needed. Also, it didn't work at the time, if I recall. Anyone is free to submit pull-requests to improve this.