Proposed feature: Change nation ruleset translation_domain "freeciv" as "freeciv-core"

[cazfi]

osdn #42111: targeted to freeciv-3.1: The actual translation domain for freeciv core, including core nations, was renamed to "freeciv-core" in 3.0 already, but the definition to use it remained in nation files as 'translation_domain = "freeciv"'. The proposal is to change that definition to use the actual domain name "freeciv-core".

The never were intentionally left out-of-sync. It was just something that we failed to notice when the domain rename was made.

[nef]

I have not noticed a explanation of 'translation_domain = "freeciv"'' in the ruleset files. Could you give a short description or a reference.

[cazfi]

Freeciv translations are provided in three different sets/domains. The original reason for splitting between "freeciv-core" and "freeciv-nations" domains was that former is made a higher priority for the translators to work on. It's possible to play freeciv only using translations from freeciv-core, while freeciv-nations has translations for names and legends of nations in the extended set.

By default, translations for nation names and legends are drawn from "freeciv-nations" domain, but those nations that have their translation in the freeciv-core domain get their translations drawn from there by defining translation_domain = "freeciv-core".

When the format was originally implemented, the idea was that it would make it possible in the future to support e.g. ruleset provided domains (translations for nations that are only in the modpack, not part of main freeciv)