Qt feature request

What would you like to see in Freeciv? Do you have a good idea what should be improved or how?
User avatar
GriffonSpade
Elite
Posts: 578
Joined: Mon Apr 29, 2013 4:41 pm

Re: Qt feature request

Postby GriffonSpade » Tue Jul 18, 2017 10:44 pm

The unit combat popup in QT3.0 is pretty useful, but it has a few problems with it: It doesn't purge 'old' combats when it pops back up, which causes a bit of confusion about the combats that actually just happened, and the dang thing is HUGE, obstructing a significant portion of the screen, and I can't even see the bottom unit in its normal place through the chatbox. Any chance it could be made to purge all the old combats when it vanishes and shrink the size a bit?

User avatar
mir3x
Veteran
Posts: 110
Joined: Sat Jan 30, 2016 6:17 pm

Re: Qt feature request

Postby mir3x » Wed Jul 19, 2017 4:59 am

It shows only last 5 combats, rest is purged ( and newest battles goes top).
Its done not to purge old eg. if you go toilet and go back and enemy killed some of your units, you would see how much wounded his units are.
Maybe I just make them 2x lower ? ( or maybe fit automatically to take max half of window height ? - so 1 combat would alwyas take 10% of window height)
( I tested always on amplio only, seems larger tilesets have such problems)

User avatar
GriffonSpade
Elite
Posts: 578
Joined: Mon Apr 29, 2013 4:41 pm

Re: Qt feature request

Postby GriffonSpade » Wed Jul 19, 2017 3:01 pm

Hmm, oh, how about a time stamp for the combats? Maybe.

User avatar
mir3x
Veteran
Posts: 110
Joined: Sat Jan 30, 2016 6:17 pm

Re: Qt feature request

Postby mir3x » Mon Sep 11, 2017 9:19 pm

[quote="GriffonSpade"] Zoom seems to have offsets misaligned on the 'corner style' isohex tilesets, such as ocean tiles, at least for Hexemplio. (Nothing was noticable in Isophex)[/quote]

I cannot see what you mean. If you have time attach soem screenshot with big red circle what is wrong.
In code i found only that:
case CELL_CORNER:
...
dlp->offset_x = dlp->offset_y = 0;

User avatar
mir3x
Veteran
Posts: 110
Joined: Sat Jan 30, 2016 6:17 pm

Re: Qt feature request

Postby mir3x » Mon Sep 11, 2017 9:21 pm

[quote="mir3x"][quote="GriffonSpade"] Zoom seems to have offsets misaligned on the 'corner style' isohex tilesets, such as ocean tiles, at least for Hexemplio. (Nothing was noticable in Isophex)[/quote]

I cannot see what you mean. If you have time attach soem screenshot with big red circle what is wrong.
In code i found only that:
case CELL_CORNER:
dlp->offset_x = dlp->offset_y = 0;
Not sure how to scale that 0.

(there is also DARKNESS_CORNER, but it looks ok too )

User avatar
mir3x
Veteran
Posts: 110
Joined: Sat Jan 30, 2016 6:17 pm

Re: Qt feature request

Postby mir3x » Mon Sep 11, 2017 9:21 pm

[quote="GriffonSpade"] Zoom seems to have offsets misaligned on the 'corner style' isohex tilesets, such as ocean tiles, at least for Hexemplio. (Nothing was noticable in Isophex)[/quote]

I cannot see what you mean. If you have time attach soem screenshot with big red circle what is wrong.
In code i found only that:
case CELL_CORNER:
dlp->offset_x = dlp->offset_y = 0;
Not sure how to scale that 0.

(there is also DARKNESS_CORNER, but it looks ok too )

User avatar
mir3x
Veteran
Posts: 110
Joined: Sat Jan 30, 2016 6:17 pm

Re: Qt feature request

Postby mir3x » Mon Sep 11, 2017 9:21 pm

mir3x wrote:
GriffonSpade wrote: Zoom seems to have offsets misaligned on the 'corner style' isohex tilesets, such as ocean tiles, at least for Hexemplio. (Nothing was noticable in Isophex)


I cannot see what you mean. If you have time attach soem screenshot with big red circle what is wrong.
In code i found only that:
case CELL_CORNER:
dlp->offset_x = dlp->offset_y = 0;
Not sure how to scale that 0.

(there is also DARKNESS_CORNER, but it looks ok too )

User avatar
mir3x
Veteran
Posts: 110
Joined: Sat Jan 30, 2016 6:17 pm

Re: Qt feature request

Postby mir3x » Mon Sep 11, 2017 9:22 pm

[quote="GriffonSpade"] Zoom seems to have offsets misaligned on the 'corner style' isohex tilesets, such as ocean tiles, at least for Hexemplio. (Nothing was noticable in Isophex)[/quote]

I cannot see what you mean. If you have time attach soem screenshot with big red circle what is wrong.
In code i found only that:
case CELL_CORNER:
dlp->offset_x = dlp->offset_y = 0;
Not sure how to scale that 0.

(there is also DARKNESS_CORNER, but it looks ok too )

User avatar
mir3x
Veteran
Posts: 110
Joined: Sat Jan 30, 2016 6:17 pm

Re: Qt feature request

Postby mir3x » Mon Sep 11, 2017 9:22 pm

GriffonSpade wrote: Zoom seems to have offsets misaligned on the 'corner style' isohex tilesets, such as ocean tiles, at least for Hexemplio. (Nothing was noticable in Isophex)


I cannot see what you mean. If you have time attach soem screenshot with big red circle what is wrong.
In code i found only that:
case CELL_CORNER:
dlp->offset_x = dlp->offset_y = 0;
Not sure how to scale that 0.

(there is also DARKNESS_CORNER, but it looks ok too )

I found some xxx_offsets which were not scaled, but they have no effect on sea tiles.

User avatar
GriffonSpade
Elite
Posts: 578
Joined: Mon Apr 29, 2013 4:41 pm

Re: Qt feature request

Postby GriffonSpade » Tue Sep 12, 2017 2:23 am

mir3x wrote:
GriffonSpade wrote: Zoom seems to have offsets misaligned on the 'corner style' isohex tilesets, such as ocean tiles, at least for Hexemplio. (Nothing was noticable in Isophex)


I cannot see what you mean. If you have time attach soem screenshot with big red circle what is wrong.
In code i found only that:
case CELL_CORNER:
dlp->offset_x = dlp->offset_y = 0;
Not sure how to scale that 0.

(there is also DARKNESS_CORNER, but it looks ok too )

I found some xxx_offsets which were not scaled, but they have no effect on sea tiles.

This was made with 2.6 beta 14f82de271. Haven't checked newer ones.
Untitled.png