trireme on land exploit

What would you like to see in Freeciv? Do you have a good idea what should be improved or how?
Wahazar
Elite
Posts: 362
Joined: Mon Jul 02, 2018 1:49 pm

Re: trireme on land exploit

Post by Wahazar »

Well, lets summarize to clear possible misunderstanding.
  • There can be following cases:
  • ship with land units on ocean: attacked is ship, if die, land units die - it is normal behavior.
  • ship with air units on ocean: attacked is ship, but air units survive - it is weird behavior.
  • ship with land units on river: is treated like a normal stack (best defender is attacked) but this stack is not visible for attacker. Moreover, loaded units can be fortified. Very weird and unfair behavior.
The second case seems to be effect of code wipe out units, which can't survive - it is in version 2.5, but can't find it in current branch - it was fixed?
I also don't understand, where the third case is coded.
I found unit_attack_any_at_tile_result function in common/combat.c where transported units are excluded from being taken into attack consideration.
Augmented2 ruleset/modpack for freeciv2.6: http://forum.freeciv.org/f/viewtopic.php?f=11&t=91047
cazfi
Elite
Posts: 3077
Joined: Tue Jan 29, 2013 6:54 pm

Re: trireme on land exploit

Post by cazfi »

Wahazar wrote:* ship with land units on river: is treated like a normal stack (best defender is attacked) but this stack is not visible for attacker. Moreover, loaded units can be fortified. Very weird and unfair behavior.
...
I also don't understand, where the third case is coded.
unit_can_defend_here():

Code: Select all

  /* Do not just check if unit is transported.
   * Even transported units may step out from transport to fight,
   * if this is their native terrain. */
  return (can_unit_exist_at_tile(punit, unit_tile(punit))
          && (ptrans == NULL || can_unit_unload(punit, ptrans)));
Wahazar
Elite
Posts: 362
Joined: Mon Jul 02, 2018 1:49 pm

Re: trireme on land exploit

Post by Wahazar »

Thanks, so it is intended behavior. I always unloaded units from trireme between turns, to avoid its lost.
I understand, that this hack is to avoid such unloading/loading units manually - unfortunately this implementation is debatable.
It is unfair that player didn't see stack, but must to fight with it, and that it is possible to fortify inside boat.
Either stack should to be visible, or just behavior similar to carrier with airplanes should be applied (if you kill trireme on land, units inside can survive and you need to fight with them later).
Augmented2 ruleset/modpack for freeciv2.6: http://forum.freeciv.org/f/viewtopic.php?f=11&t=91047
Ignatus
Elite
Posts: 644
Joined: Mon Nov 06, 2017 12:05 pm
Location: St.Petersburg, Russia
Contact:

Re: trireme on land exploit

Post by Ignatus »

Grumbler
Posts: 9
Joined: Wed Nov 20, 2019 7:55 pm

Re: trireme on land exploit

Post by Grumbler »

speaking of triremes and slightly OT, i'm rather new to freeciv and was surprised by the feature that they can travel rivers (which isn't in any commercial civ i know of), but it makes sense.

this also offers tactical possibilities.

when you upgrade triremes though, they become transports. that makes no sense, as they lose the ability to travel rivers then. keeping triremes is anachronistic though.

thus, maybe there should be a new equivalent unit for the modern era. maybe a motorboat?
User avatar
Corbeau
Elite
Posts: 1291
Joined: Mon Jan 13, 2014 11:13 pm

Re: trireme on land exploit

Post by Corbeau »

We are experimenting with rulesets a lot in the Longturn community, drop by and play a game :)
--
* Freeciv LongTurn, a community of one-turn-per-day players and developers
* LongTurn Blog - information nexus with stuff and stuff and stuff
* Longturn Discord server; real-time chatting, discussing, quarrelling, trolling, gaslighting...
Ignatus
Elite
Posts: 644
Joined: Mon Nov 06, 2017 12:05 pm
Location: St.Petersburg, Russia
Contact:

Re: trireme on land exploit

Post by Ignatus »

In LT49 triremes just never expire, they look clumsy near AEGIS cruisers but they do their job. I have seen graphics for steamboats on "Art and tilesets", probably in some rulesets somebody had a Trireme+ unit.
Wahazar
Elite
Posts: 362
Joined: Mon Jul 02, 2018 1:49 pm

Re: trireme on land exploit

Post by Wahazar »

Ignatus wrote: I have seen graphics for steamboats on "Art and tilesets", probably in some rulesets somebody had a Trireme+ unit.
Yes, for example augmented2 modpack have whole branch of Coaster class, capable to go on shallow sea or river.
As Grumbler stated, it offers new tactical possibilities, which may drastically change game balance. In case of augmented2, where land units are divided into different classes, early units like Trireme can carry only infantry, while more advanced units can carry also cavalry, and most advanced Diesel Barge can carry all including artillery/tanks. At this point of tech tree you have also Marines, thus such Diesel Barge doesn't abruptly change game balance.

BTW, it would be awesome to have unit weight instead of/beside of unit count capacity, it would be useful to limit transport capabilities instead of using classes, and to get rid of infamous 10 elephants/11 archers effect.
Augmented2 ruleset/modpack for freeciv2.6: http://forum.freeciv.org/f/viewtopic.php?f=11&t=91047
sveinung
Elite
Posts: 548
Joined: Wed Feb 20, 2013 4:50 pm

Re: trireme on land exploit

Post by sveinung »

Feature #848689 is related to this subject.
Lachu
Elite
Posts: 472
Joined: Sat May 04, 2013 2:19 pm

Re: trireme on land exploit

Post by Lachu »

About ability to self-defend of unloaded unit. Maybe make fortify action disabled, when unit was unloaded on the same turn? Of course, fortify, when loaded should be disabled too.
Post Reply