Geopolitical correction to standard tileset(s)

Contribute, display and discuss art and tilesets for use in Freeciv here.
User avatar
XYZ
Veteran
Posts: 139
Joined: Fri Jan 31, 2014 12:00 pm

Re: Geopolitical correction to standard tileset(s)

Postby XYZ » Sun Sep 17, 2017 4:06 pm

I meant that "official"-"default" nation that as far as Im concerned is called nation.ruleset.

User avatar
Corbeau
Elite
Posts: 622
Joined: Mon Jan 13, 2014 11:13 pm

Re: Geopolitical correction to standard tileset(s)

Postby Corbeau » Sun Sep 17, 2017 4:20 pm

Well, the flag image is not an issue of nation.ruleset.

User avatar
dunnoob
Hardened
Posts: 268
Joined: Mon Dec 23, 2013 3:13 am
Location: Hamburg
Contact:

Re: Geopolitical correction to standard tileset(s)

Postby dunnoob » Thu Sep 21, 2017 6:05 pm

XYZ wrote:Only problem is that is has been stuck forever and Im to incompetent to push through... :P
Well, at least it's a known problem, but my 2.5.6 tracking request is now obsolete. On HRM the tracking is apparently automatical, if you submit an issue for 2.5.10 it ends up in 2.5.10. Of course the admins can change it to, say, 3.1.0.

More competence would require more rights. For SVN it was relatively simple, the opposite of co (check out) would be check in. For github I'm lost, one way is fork + pull request, but that sounds like nuking spies.:) Submitting patches again on HRM presumably won't help, all developers are busy with code, and have no time for nations/flags/scenarios, let alone wiki/forum/web site admin crap.

Back to the question of alternative flags, the Freeciv Catalan flag does not have a blue or red star. Maybe Freeciv should get an aspirant nations group, if we can determine some way to reject nonsense. :?:

Caedo
Elite
Posts: 376
Joined: Sun Feb 10, 2013 10:21 pm
Location: Germany

Re: Geopolitical correction to standard tileset(s)

Postby Caedo » Thu Sep 21, 2017 6:52 pm

dunnoob wrote:More competence would require more rights. For SVN it was relatively simple, the opposite of co (check out) would be check in. For github I'm lost, one way is fork + pull request, but that sounds like nuking spies.:) Submitting patches again on HRM presumably won't help, all developers are busy with code, and have no time for nations/flags/scenarios, let alone wiki/forum/web site admin crap.

Typically, when working with github, fork + pull request would be the way to go (that's how git works). However, the only thing Freeciv currently uses github for is hosting its source code. Changes are made via patches on HRM, which, of course, means more work for the maintainers.

cazfi
Elite
Posts: 1345
Joined: Tue Jan 29, 2013 6:54 pm

Re: Geopolitical correction to standard tileset(s)

Postby cazfi » Fri Sep 22, 2017 1:14 am

Caedo wrote:Typically, when working with github, fork + pull request would be the way to go (that's how git works). However, the only thing Freeciv currently uses github for is hosting its source code. Changes are made via patches on HRM, which, of course, means more work for the maintainers.

We can take github pull requests. It's not necessary to attach patch as a file to hrm ticket. However, hrm ticket is always needed for having single place for the review process.