Hex tileset needs very large y offsets, problems ensue

Contribute, display and discuss art and tilesets for use in Freeciv here.
cazfi
Elite
Posts: 1584
Joined: Tue Jan 29, 2013 6:54 pm

Re: Hex tileset needs very large y offsets, problems ensue

Postby cazfi » Mon Dec 02, 2013 5:58 am

HanduMan wrote:

Code: Select all

; Basic tile sizes:
normal_tile_width  = 128
normal_tile_height = 34
small_tile_width   = 15
small_tile_height  = 20

; Basic tile style.
is_isometric = 0
is_hex = 1
hex_side = 30

Note that to make an isometric hex set we need to define is_isometric = 0 :roll:

Reading the code this seems to make no difference.

from TRUNK:

Code: Select all

  if (is_hex) {
    ...
    /* Hex tilesets are drawn the same as isometric. */
    /* FIXME: There will be other legal values to be used with hex
     * tileset in the future, and this would just overwrite it. */
    t->type = TS_ISOMETRIC;
  }

cazfi
Elite
Posts: 1584
Joined: Tue Jan 29, 2013 6:54 pm

Re: Hex tileset needs very large y offsets, problems ensue

Postby cazfi » Mon Dec 02, 2013 6:08 am

cazfi wrote:Reading the code this seems to make no difference.

My mistake. Before type is forced to isometric for the rest of the tileset handling, type given in tilespec is used to set hex height and width.

cazfi
Elite
Posts: 1584
Joined: Tue Jan 29, 2013 6:54 pm

Re: Hex tileset needs very large y offsets, problems ensue

Postby cazfi » Mon Dec 02, 2013 8:08 pm

Treefingers wrote:
cazfi wrote:If you have bug to report, please report it to bug tracker
You're right, I should (and will). Though I'm never sure what to report for bugs that are more at the aesthetic end of things, since it's always debatable whether there's a problem in the first place, and the solution tends to be a matter of taste. I'll head over and do what I can, though.

Did you? I didn't see anything related on a cursory look to the tracker. As for not reporting something that would not be deemed real bug in the end, that's to be decided when the report is handled, isn't it? Very low percentage of the reports we receive are turned to "wontfix", though the discussion about the report can change the action taken quite a lot from what reporter was originally thinkg (most obvious cases being that instead of changing the code we just improve the documentation to state how things work).

In this case I would already have half-finished patch that I'd like to attach to the ticket.

Treefingers
Posts: 20
Joined: Fri Nov 08, 2013 11:40 pm

Re: Hex tileset needs very large y offsets, problems ensue

Postby Treefingers » Thu Dec 05, 2013 3:50 am

No, sorry, I hadn't yet. I decided to install 2.4 to check things again on the most recent version. Then higher-priority things pulled me away for a while.

Filed the bug today, though:
http://gna.org/bugs/index.php?21329

cazfi
Elite
Posts: 1584
Joined: Tue Jan 29, 2013 6:54 pm

Re: Hex tileset needs very large y offsets, problems ensue

Postby cazfi » Wed Jan 01, 2014 11:31 pm

Treefingers wrote:Filed the bug today, though:
http://gna.org/bugs/index.php?21329

That ticket is now closed. Until someone comes back stating that the fix issued is not enough (it's not 100% fix, but just an improvement to the situation), I consider this now resolved.