Should ruleup clean up the ruleset by default?

Contribute, display and discuss rulesets and modpacks for use in Freeciv here.
sveinung
Elite
Posts: 542
Joined: Wed Feb 20, 2013 4:50 pm

Should ruleup clean up the ruleset by default?

Postby sveinung » Thu Feb 25, 2021 12:36 pm

The tool ruleup - I think it first appeared in 3.0 - is able to read a ruleset from the previous version, upgrade it to the current version, and save it. The ruleset compatibility code adds a lot of stuff that is unused to support upgrading other rulesets that needs those features. In 3.1 I have made it clean up some - but not all - unused stuff by default. This includes unused items that were there before the upgrade. A new argument, currently called --dirty, turns the clean up off. Would you prefer if it didn't clean up the ruleset by default and that you would have to specify as an argument - say --clean, that you wanted the clean up?

User avatar
Canik
Veteran
Posts: 76
Joined: Tue Jul 18, 2017 4:26 am

Re: Should ruleup clean up the ruleset by default?

Postby Canik » Mon Mar 01, 2021 4:37 pm

I'd prefer it by dirty default please.

User avatar
Caedo
Elite
Posts: 512
Joined: Sun Feb 10, 2013 10:21 pm
Location: Stuttgart, Germany

Re: Should ruleup clean up the ruleset by default?

Postby Caedo » Mon Mar 01, 2021 7:06 pm

I figure going dirty by default would probably be the safer route – unused items from before the upgrade might have been there for a reason.
~ A.V. L.

sveinung
Elite
Posts: 542
Joined: Wed Feb 20, 2013 4:50 pm

Re: Should ruleup clean up the ruleset by default?

Postby sveinung » Tue Mar 02, 2021 1:55 am

Thank you for your feed back. Than dirty by default it is.