Page 1 of 1

Veteran levels

Posted: Sat Feb 17, 2018 1:30 pm
by Corbeau
Can someone check the code to see what is the maximum number of veteran levels for workers and military?

Related to:
veteran_names
veteran_raise_chance
veteran_work_raise_chance
veteran_power_fact
veteran_move_bonus

I have 17 levels in my ruleset, for some reason it isn't working and there is no error message when loading the ruleset. One other ruleset has 10 and it is working.

Re: Veteran leves

Posted: Sat Feb 17, 2018 1:57 pm
by cazfi
Maximum number of veteran levels is 20.

Can you send the ruleset to me for inspection?

Re: Veteran leves

Posted: Sat Feb 17, 2018 4:48 pm
by Alien Valkyrie
Does the tileset you use define 17 veteran level icons? Supplied tilesets only define 10.

Re: Veteran leves

Posted: Sat Feb 17, 2018 6:43 pm
by Corbeau
cazfi wrote:Maximum number of veteran levels is 20.

Can you send the ruleset to me for inspection?
It's attached to this post:
http://forum.freeciv.org/f/viewtopic.ph ... 385#p80734
Caedo wrote:Does the tileset you use define 17 veteran level icons? Supplied tilesets only define 10.
Ah! Good one! Nope.

On the other hand, if that's a problem, wouldn't that show error when loading the ruleset?

Re: Veteran levels

Posted: Sun Feb 18, 2018 11:33 am
by wieder
The ruleset in question can also be found from here:

https://github.com/longturn/games/commits/master/LT42

Re: Veteran leves

Posted: Sun Feb 18, 2018 2:56 pm
by Alien Valkyrie
Corbeau wrote:On the other hand, if that's a problem, wouldn't that show error when loading the ruleset?
That's the question – is it a problem with the client or the server? Does loading the ruleset on a standalone server work?

Re: Veteran leves

Posted: Sun Feb 18, 2018 2:59 pm
by cazfi
Corbeau wrote:On the other hand, if that's a problem, wouldn't that show error when loading the ruleset?
I haven't checked but I'm quite sure it's not considered an error. It just means that multiple veteran levels share same icon.

Re: Veteran levels

Posted: Sun Feb 18, 2018 3:11 pm
by Corbeau
I tested it by loading the ruleset, the ruleset definitely loaded, no error, and some other specific settings from the ruleset worked.

Re: Veteran levels

Posted: Sun Feb 18, 2018 3:16 pm
by cazfi
So the ruleset has global veterancy system with 17 veterancy levels, and some units have their own veterancy systems, such as Workers with just one veterancy level.

I tested these by going to Editor mode and checking what veterancy levels it allowed one to set for units. Explorers could have any of levels 0-16, Workers just level 0.

Seems to work just like defined.

Re: Veteran levels

Posted: Sun Feb 18, 2018 3:56 pm
by Corbeau
Oh hell... I missed those. Thanks.

So if I simply delete the "individual" veterancy levels for Workers and Engineers, it should work, right?