Veteran levels

Contribute, display and discuss rulesets and modpacks for use in Freeciv here.
User avatar
Corbeau
Elite
Posts: 719
Joined: Mon Jan 13, 2014 11:13 pm

Veteran levels

Postby Corbeau » Sat Feb 17, 2018 1:30 pm

Can someone check the code to see what is the maximum number of veteran levels for workers and military?

Related to:
veteran_names
veteran_raise_chance
veteran_work_raise_chance
veteran_power_fact
veteran_move_bonus

I have 17 levels in my ruleset, for some reason it isn't working and there is no error message when loading the ruleset. One other ruleset has 10 and it is working.
Last edited by Corbeau on Sat Feb 17, 2018 6:46 pm, edited 1 time in total.

cazfi
Elite
Posts: 1472
Joined: Tue Jan 29, 2013 6:54 pm

Re: Veteran leves

Postby cazfi » Sat Feb 17, 2018 1:57 pm

Maximum number of veteran levels is 20.

Can you send the ruleset to me for inspection?

Caedo
Elite
Posts: 418
Joined: Sun Feb 10, 2013 10:21 pm
Location: Germany

Re: Veteran leves

Postby Caedo » Sat Feb 17, 2018 4:48 pm

Does the tileset you use define 17 veteran level icons? Supplied tilesets only define 10.

User avatar
Corbeau
Elite
Posts: 719
Joined: Mon Jan 13, 2014 11:13 pm

Re: Veteran leves

Postby Corbeau » Sat Feb 17, 2018 6:43 pm

cazfi wrote:Maximum number of veteran levels is 20.

Can you send the ruleset to me for inspection?


It's attached to this post:
viewtopic.php?f=11&t=75385#p80734

Caedo wrote:Does the tileset you use define 17 veteran level icons? Supplied tilesets only define 10.

Ah! Good one! Nope.

On the other hand, if that's a problem, wouldn't that show error when loading the ruleset?

wieder
Hardened
Posts: 195
Joined: Thu Jul 27, 2017 10:43 am

Re: Veteran levels

Postby wieder » Sun Feb 18, 2018 11:33 am

The ruleset in question can also be found from here:

https://github.com/longturn/games/commits/master/LT42

Caedo
Elite
Posts: 418
Joined: Sun Feb 10, 2013 10:21 pm
Location: Germany

Re: Veteran leves

Postby Caedo » Sun Feb 18, 2018 2:56 pm

Corbeau wrote:On the other hand, if that's a problem, wouldn't that show error when loading the ruleset?

That's the question – is it a problem with the client or the server? Does loading the ruleset on a standalone server work?

cazfi
Elite
Posts: 1472
Joined: Tue Jan 29, 2013 6:54 pm

Re: Veteran leves

Postby cazfi » Sun Feb 18, 2018 2:59 pm

Corbeau wrote:On the other hand, if that's a problem, wouldn't that show error when loading the ruleset?

I haven't checked but I'm quite sure it's not considered an error. It just means that multiple veteran levels share same icon.

User avatar
Corbeau
Elite
Posts: 719
Joined: Mon Jan 13, 2014 11:13 pm

Re: Veteran levels

Postby Corbeau » Sun Feb 18, 2018 3:11 pm

I tested it by loading the ruleset, the ruleset definitely loaded, no error, and some other specific settings from the ruleset worked.

cazfi
Elite
Posts: 1472
Joined: Tue Jan 29, 2013 6:54 pm

Re: Veteran levels

Postby cazfi » Sun Feb 18, 2018 3:16 pm

So the ruleset has global veterancy system with 17 veterancy levels, and some units have their own veterancy systems, such as Workers with just one veterancy level.

I tested these by going to Editor mode and checking what veterancy levels it allowed one to set for units. Explorers could have any of levels 0-16, Workers just level 0.

Seems to work just like defined.

User avatar
Corbeau
Elite
Posts: 719
Joined: Mon Jan 13, 2014 11:13 pm

Re: Veteran levels

Postby Corbeau » Sun Feb 18, 2018 3:56 pm

Oh hell... I missed those. Thanks.

So if I simply delete the "individual" veterancy levels for Workers and Engineers, it should work, right?