Corbeau wrote:Actually, the README.effects that I have contains a list of effects and a very rough description of what they do, but not *how* they do it. For example, if you guys hadn't told me, there is no way in hell that I'd be able to figure out myself that "Terrain", "Mountain", "Local" also works for creating veteran units or that you can't have multiple automatic upgrading improvements.
Think about it. The Upgrade_Unit effect dictates how many units the player gets upgraded per turn. If it was evaluated at a city range, then in the classic ruleset, Leonardo's Workshop would give you one free upgrade per turn per city.
And I don't know that Terrain requirements work for Veteran_Build. I just assumed that, since it's evaluated at a city range (evident from the way Barracks work). If you haven't tested it yet, I wouldn't take it for granted.
The way I see it, there's enough information in README.effects that if you already know those things, you'll feel like it's obvious, but if you don't know yet, it can be quite a riddle. So if you're ever not sure, and thinking about it for a moment doesn't make it clear, just test it. There are a lot of interesting things to discover.