forum.freeciv.org

The Output_Bonus effect is only evaluated against the city, not against the tile it's on, so any Tile-ranged requirements in general won't work there. This could be changed in principle; there doesn't seem to be any particular reason for this.

Moved national border claiming rules to the ruleset. RM #588 New Tile_Claimable effect controls whether a border source can claim a target tile. The Claim_Ocean and Claim_Ocean_Limited tech flags have been removed / turned into user flags (increasing the maximum number of user tech flags by 2).

Added new requirement type TileRel to check the relationship between two tiles. RM #614, RM #654, RM #678

This is only available in the same places MaxDistanceSq (see above) is available. Current possible values are primarily about the tiles' continents/oceans.

Added new requirement type MaxRegionTiles to count tiles that are part of the same region (continent or ocean). RM #629 , RM #652 This requirement checks the number of tiles in the given range that are part of the same region as the target tile. This allows detecting smaller islands and lakes (when ...

Added new requirement type MaxDistanceSq to check the (squared) distance between tiles. RM #616 This is only available in contexts where there are two separate relevant tiles: primarily action enablers, but also (at time of writing) the Trade_Revenue_Bonus (source and destination), Unit_Bribe_Cost_P...

Removed limit on requirement vector length. RM #541

Note that at some point beyond a couple hundred requirements in one place, you will run into issues transmitting ruleset data to the client as individual packets get too large. I don't expect this to ever happen in practice.

A better solution would be actually replacing specific parts of map generation procedure with custom parts (e.g., define callbacks for creating or postprocessing height map, for selecting terrains etc.) with an ability to use binary functions for other parts. I'd be wary of things like that — anyth...

I figure going dirty by default would probably be the safer route – unused items from before the upgrade might have been there for a reason.

I just noticed there's a two-and-a-half-year-old ticket by JTN on this topic that I hadn't noticed when starting this thread – the same issue I brought up above regarding the assumption that all year fragments are of uniform length is mentioned there as well. Now, one thing we could do is give rules...

Paches welcome (from any reader)! Since I'm currently in the CanOccupyCity "area" mentally I would probably be quick to review them. If you use utype_can_do_action_result() in the 3.1 patches you won't delay generalized actions. Feel free to use utype_can_do_action() if you don't want to ...